lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 097/348] media: siano: fix device register error path
    Date
    From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

    [ Upstream commit 5368b1ee2939961a16e74972b69088433fc52195 ]

    As reported by smatch:
    drivers/media/common/siano/smsdvb-main.c:1231 smsdvb_hotplug() warn: '&client->entry' not removed from list

    If an error occur at the end of the registration logic, it won't
    drop the device from the list.

    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/common/siano/smsdvb-main.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/media/common/siano/smsdvb-main.c b/drivers/media/common/siano/smsdvb-main.c
    index ae17407e477a..7cc654bc52d3 100644
    --- a/drivers/media/common/siano/smsdvb-main.c
    +++ b/drivers/media/common/siano/smsdvb-main.c
    @@ -1176,6 +1176,10 @@ static int smsdvb_hotplug(struct smscore_device_t *coredev,
    return 0;

    media_graph_error:
    + mutex_lock(&g_smsdvb_clientslock);
    + list_del(&client->entry);
    + mutex_unlock(&g_smsdvb_clientslock);
    +
    smsdvb_debugfs_release(client);

    client_error:
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 08:19    [W:4.054 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site