lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 474/700] net: bcmgenet: Fix attaching to PYH failed on RPi 4B
    Date
    From: Jian-Hong Pan <jhp@endlessos.org>

    [ Upstream commit b2ac9800cfe0f8da16abc4e74e003440361c112e ]

    The Broadcom UniMAC MDIO bus from mdio-bcm-unimac module comes too late.
    So, GENET cannot find the ethernet PHY on UniMAC MDIO bus. This leads
    GENET fail to attach the PHY as following log:

    bcmgenet fd580000.ethernet: GENET 5.0 EPHY: 0x0000
    ...
    could not attach to PHY
    bcmgenet fd580000.ethernet eth0: failed to connect to PHY
    uart-pl011 fe201000.serial: no DMA platform data
    libphy: bcmgenet MII bus: probed
    ...
    unimac-mdio unimac-mdio.-19: Broadcom UniMAC MDIO bus

    This patch adds the soft dependency to load mdio-bcm-unimac module
    before genet module to avoid the issue.

    Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC MDIO controller driver")
    Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=213485
    Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/broadcom/genet/bcmgenet.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    index fcca023f22e5..41f7f078cd27 100644
    --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
    @@ -4296,3 +4296,4 @@ MODULE_AUTHOR("Broadcom Corporation");
    MODULE_DESCRIPTION("Broadcom GENET Ethernet controller driver");
    MODULE_ALIAS("platform:bcmgenet");
    MODULE_LICENSE("GPL");
    +MODULE_SOFTDEP("pre: mdio-bcm-unimac");
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 09:53    [W:4.038 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site