lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 521/700] ASoC: rt5682: Disable irq on shutdown
    Date
    From: Stephen Boyd <swboyd@chromium.org>

    [ Upstream commit 47bcb1c7108363418cd578283333d72e310dfeaa ]

    We cancel the work queues, and reset the device on shutdown, but the irq
    isn't disabled so the work queues could be queued again. Let's disable
    the irq during shutdown so that we don't have to worry about this device
    trying to do anything anymore. This fixes a problem seen where the i2c
    bus is shutdown at reboot but this device irq still comes in and tries
    to make another i2c transaction when the bus doesn't work.

    Cc: Jairaj Arava <jairaj.arava@intel.com>
    Cc: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
    Cc: Pierre-Louis Bossart <pierre-louis.bossart@intel.com>
    Cc: Shuming Fan <shumingf@realtek.com>
    Cc: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
    Fixes: 45a2702ce109 ("ASoC: rt5682: Fix panic in rt5682_jack_detect_handler happening during system shutdown")
    Signed-off-by: Stephen Boyd <swboyd@chromium.org>
    Link: https://lore.kernel.org/r/20210508075151.1626903-1-swboyd@chromium.org
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/rt5682-i2c.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c
    index 93c1603b42f1..8265b537ff4f 100644
    --- a/sound/soc/codecs/rt5682-i2c.c
    +++ b/sound/soc/codecs/rt5682-i2c.c
    @@ -273,6 +273,7 @@ static void rt5682_i2c_shutdown(struct i2c_client *client)
    {
    struct rt5682_priv *rt5682 = i2c_get_clientdata(client);

    + disable_irq(client->irq);
    cancel_delayed_work_sync(&rt5682->jack_detect_work);
    cancel_delayed_work_sync(&rt5682->jd_check_work);

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 09:52    [W:2.273 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site