Messages in this thread | | | From | Sumit Garg <> | Date | Mon, 12 Jul 2021 12:44:48 +0530 | Subject | Re: [PATCH v4 2/4] kdb: Get rid of redundant kdb_register_flags() |
| |
On Sat, 10 Jul 2021 at 03:07, Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Fri, Jul 9, 2021 at 3:43 AM Sumit Garg <sumit.garg@linaro.org> wrote: > > > > Commit e4f291b3f7bb ("kdb: Simplify kdb commands registration") > > allowed registration of pre-allocated kdb commands with pointer to > > struct kdbtab_t. Lets switch other users as well to register pre- > > allocated kdb commands via: > > - Changing prototype for kdb_register() to pass a pointer to struct > > kdbtab_t instead. > > - Embed kdbtab_t structure in kdb_macro_t rather than individual params. > > > > With these changes kdb_register_flags() becomes redundant and hence > > removed. Also, since we have switched all users to register > > pre-allocated commands, "is_dynamic" flag in struct kdbtab_t becomes > > redundant and hence removed as well. > > > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org> > > Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org> > > Looking at v3 responses [1], seems like you forgot to add again: > > Suggested-by: Daniel Thompson <daniel.thompson@linaro.org> >
Ah, it was mistakenly dropped, I will add it again.
> This also looks good to me now. > > Reviewed-by: Douglas Anderson <dianders@chromium.org>
Thanks, -Sumit
| |