lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 438/700] mt76: mt7921: remove redundant check on type
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 1921b8925c6f2a171af6294bba6af733da2409b9 ]

    Currently in the switch statement case where type is
    NL80211_IFTYPE_STATION there is a check to see if type
    is not NL80211_IFTYPE_STATION. This check is always false
    and is redundant dead code that can be removed.

    Addresses-Coverity: ("Logically dead code")
    Fixes: e0f9fdda81bd ("mt76: mt7921: add ieee80211_ops")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/mediatek/mt76/mt7921/main.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/main.c b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
    index c6e8857067a3..05ba9cdffb1a 100644
    --- a/drivers/net/wireless/mediatek/mt76/mt7921/main.c
    +++ b/drivers/net/wireless/mediatek/mt76/mt7921/main.c
    @@ -239,9 +239,6 @@ static int get_omac_idx(enum nl80211_iftype type, u64 mask)
    if (i)
    return i - 1;

    - if (type != NL80211_IFTYPE_STATION)
    - break;
    -
    /* next, try to find a free repeater entry for the sta */
    i = get_free_idx(mask >> REPEATER_BSSID_START, 0,
    REPEATER_BSSID_MAX - REPEATER_BSSID_START);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 09:51    [W:3.800 / U:0.692 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site