lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 376/700] drm/rockchip: cdn-dp-core: add missing clk_disable_unprepare() on error in cdn_dp_grf_write()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit ae41d925c75b53798f289c69ee8d9f7d36432f6d ]

    After calling clk_prepare_enable(), clk_disable_unprepare() need
    be called when calling regmap_write() failed.

    Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Signed-off-by: Heiko Stuebner <heiko@sntech.de>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210519134928.2696617-1-yangyingliang@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/rockchip/cdn-dp-core.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
    index a4a45daf93f2..6802d9b65f82 100644
    --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
    +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
    @@ -73,6 +73,7 @@ static int cdn_dp_grf_write(struct cdn_dp_device *dp,
    ret = regmap_write(dp->grf, reg, val);
    if (ret) {
    DRM_DEV_ERROR(dp->dev, "Could not write to GRF: %d\n", ret);
    + clk_disable_unprepare(dp->grf_clk);
    return ret;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 09:46    [W:2.029 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site