lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 366/700] net: qrtr: ns: Fix error return code in qrtr_ns_init()
    Date
    From: Wei Yongjun <weiyongjun1@huawei.com>

    [ Upstream commit a49e72b3bda73d36664a084e47da9727a31b8095 ]

    Fix to return a negative error code -ENOMEM from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: c6e08d6251f3 ("net: qrtr: Allocate workqueue before kernel_bind")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/qrtr/ns.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
    index 8d00dfe8139e..1990d496fcfc 100644
    --- a/net/qrtr/ns.c
    +++ b/net/qrtr/ns.c
    @@ -775,8 +775,10 @@ int qrtr_ns_init(void)
    }

    qrtr_ns.workqueue = alloc_workqueue("qrtr_ns_handler", WQ_UNBOUND, 1);
    - if (!qrtr_ns.workqueue)
    + if (!qrtr_ns.workqueue) {
    + ret = -ENOMEM;
    goto err_sock;
    + }

    qrtr_ns.sock->sk->sk_data_ready = qrtr_ns_data_ready;

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 09:44    [W:3.035 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site