lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 061/700] can: peak_pciefd: pucan_handle_status(): fix a potential starvation issue in TX path
    Date
    From: Stephane Grosjean <s.grosjean@peak-system.com>

    commit b17233d385d0b6b43ecf81d43008cb1bbb008166 upstream.

    Rather than just indicating that transmission can start, this patch
    requires the explicit flushing of the network TX queue when the driver
    is informed by the device that it can transmit, next to its
    configuration.

    In this way, if frames have already been written by the application,
    they will actually be transmitted.

    Fixes: ffd137f7043c ("can: peak/pcie_fd: remove useless code when interface starts")
    Link: https://lore.kernel.org/r/20210623142600.149904-1-s.grosjean@peak-system.com
    Cc: linux-stable <stable@vger.kernel.org>
    Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/can/peak_canfd/peak_canfd.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/can/peak_canfd/peak_canfd.c
    +++ b/drivers/net/can/peak_canfd/peak_canfd.c
    @@ -351,8 +351,8 @@ static int pucan_handle_status(struct pe
    return err;
    }

    - /* start network queue (echo_skb array is empty) */
    - netif_start_queue(ndev);
    + /* wake network queue up (echo_skb array is empty) */
    + netif_wake_queue(ndev);

    return 0;
    }

    \
     
     \ /
      Last update: 2021-07-12 09:40    [W:4.018 / U:0.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site