lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 153/700] ima: Dont remove security.ima if file must not be appraised
    Date
    From: Roberto Sassu <roberto.sassu@huawei.com>

    [ Upstream commit ed1b472fc15aeaa20ddeeb93fd25190014e50d17 ]

    Files might come from a remote source and might have xattrs, including
    security.ima. It should not be IMA task to decide whether security.ima
    should be kept or not. This patch removes the removexattr() system
    call in ima_inode_post_setattr().

    Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
    Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    security/integrity/ima/ima_appraise.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/security/integrity/ima/ima_appraise.c b/security/integrity/ima/ima_appraise.c
    index 565e33ff19d0..d7cc6f897746 100644
    --- a/security/integrity/ima/ima_appraise.c
    +++ b/security/integrity/ima/ima_appraise.c
    @@ -522,8 +522,6 @@ void ima_inode_post_setattr(struct user_namespace *mnt_userns,
    return;

    action = ima_must_appraise(mnt_userns, inode, MAY_ACCESS, POST_SETATTR);
    - if (!action)
    - __vfs_removexattr(&init_user_ns, dentry, XATTR_NAME_IMA);
    iint = integrity_iint_find(inode);
    if (iint) {
    set_bit(IMA_CHANGE_ATTR, &iint->atomic_flags);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 09:30    [W:2.797 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site