lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 147/700] media: imx: imx7_mipi_csis: Fix logging of only error event counters
    Date
    From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    [ Upstream commit d2fcc9c2de1191ea80366e3658711753738dd10a ]

    The mipi_csis_events array ends with 6 non-error events, not 4. Update
    mipi_csis_log_counters() accordingly. While at it, log event counters in
    forward order, as there's no reason to log them backward.

    Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
    Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
    Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c
    index a01a7364b4b9..b365790256e4 100644
    --- a/drivers/staging/media/imx/imx7-mipi-csis.c
    +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
    @@ -597,13 +597,15 @@ static void mipi_csis_clear_counters(struct csi_state *state)

    static void mipi_csis_log_counters(struct csi_state *state, bool non_errors)
    {
    - int i = non_errors ? MIPI_CSIS_NUM_EVENTS : MIPI_CSIS_NUM_EVENTS - 4;
    + unsigned int num_events = non_errors ? MIPI_CSIS_NUM_EVENTS
    + : MIPI_CSIS_NUM_EVENTS - 6;
    struct device *dev = &state->pdev->dev;
    unsigned long flags;
    + unsigned int i;

    spin_lock_irqsave(&state->slock, flags);

    - for (i--; i >= 0; i--) {
    + for (i = 0; i < num_events; ++i) {
    if (state->events[i].counter > 0 || state->debug)
    dev_info(dev, "%s events: %d\n", state->events[i].name,
    state->events[i].counter);
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-12 09:30    [W:4.043 / U:1.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site