lkml.org 
[lkml]   [2021]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 085/700] iio: frequency: adf4350: disable reg and clk on error in adf4350_probe()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    commit c8cc4cf60b000fb9f4b29bed131fb6cf1fe42d67 upstream.

    Disable reg and clk when devm_gpiod_get_optional() fails in adf4350_probe().

    Fixes:4a89d2f47ccd ("iio: adf4350: Convert to use GPIO descriptor")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Link: https://lore.kernel.org/r/20210601142605.3613605-1-yangyingliang@huawei.com
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iio/frequency/adf4350.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/drivers/iio/frequency/adf4350.c
    +++ b/drivers/iio/frequency/adf4350.c
    @@ -563,8 +563,10 @@ static int adf4350_probe(struct spi_devi

    st->lock_detect_gpiod = devm_gpiod_get_optional(&spi->dev, NULL,
    GPIOD_IN);
    - if (IS_ERR(st->lock_detect_gpiod))
    - return PTR_ERR(st->lock_detect_gpiod);
    + if (IS_ERR(st->lock_detect_gpiod)) {
    + ret = PTR_ERR(st->lock_detect_gpiod);
    + goto error_disable_reg;
    + }

    if (pdata->power_up_frequency) {
    ret = adf4350_set_freq(st, pdata->power_up_frequency);

    \
     
     \ /
      Last update: 2021-07-12 09:24    [W:2.204 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site