Messages in this thread Patch in this message | | | Date | Sun, 11 Jul 2021 18:12:56 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH] dsa: fix for_each_child.cocci warnings |
| |
From: kernel test robot <lkp@intel.com>
For_each_available_child_of_node should have of_node_put() before return around line 423.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Alexander Lobakin <alobakin@pm.me> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Signed-off-by: Julia Lawall <julia.lawall@inria.fr> ---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: de5540965853e514a85d3b775e9049deb85a2ff3 commit: 227d72063fccb2d19b30fb4197fba478514f7d83 dsa: simplify Kconfig symbols and dependencies :::::: branch date: 15 hours ago :::::: commit date: 4 months ago
ksz_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -419,8 +419,10 @@ int ksz_switch_register(struct ksz_devic if (of_property_read_u32(port, "reg", &port_num)) continue; - if (!(dev->port_mask & BIT(port_num))) + if (!(dev->port_mask & BIT(port_num))) { + of_node_put(port); return -EINVAL; + } of_get_phy_mode(port, &dev->ports[port_num].interface); }
| |