| Subject | Re: [PATCH v12 13/17] counter: Implement signalZ_action_component_id sysfs attribute | From | David Lechner <> | Date | Sat, 10 Jul 2021 11:20:45 -0500 |
| |
On 7/5/21 3:19 AM, William Breathitt Gray wrote: > The Generic Counter chrdev interface expects users to supply component > IDs in order to select Synapses for requests. In order for users to know > what component ID belongs to which Synapse this information must be > exposed. The signalZ_action_component_id attribute provides a way for > users to discover what component ID belongs to the respective Synapse. > > Cc: David Lechner <david@lechnology.com> > Cc: Gwendal Grignou <gwendal@chromium.org> > Cc: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com> > ---
I like this better than having to scrape the number from the attribute name.
Reviewed-by: David Lechner <david@lechnology.com>
> + /* Allocate Counter attribute */ > + counter_attr = devm_kzalloc(dev, sizeof(*counter_attr), GFP_KERNEL);
nit: Comments like this are redundant and can be omitted. All 3 words in the comment are literally (abbreviated) in the next line of code so it doesn't add any new/useful information.
|