Messages in this thread | | | From | Muchun Song <> | Date | Sat, 10 Jul 2021 19:19:01 +0800 | Subject | Re: [External] [PATCH v3 3/3] mm, memcg: inline swap-related functions to improve disabled memcg config |
| |
On Sat, Jul 10, 2021 at 8:36 AM Suren Baghdasaryan <surenb@google.com> wrote: > > Inline mem_cgroup_try_charge_swap, mem_cgroup_uncharge_swap and > cgroup_throttle_swaprate functions to perform mem_cgroup_disabled static > key check inline before calling the main body of the function. This > minimizes the memcg overhead in the pagefault and exit_mmap paths when > memcgs are disabled using cgroup_disable=memory command-line option. > This change results in ~1% overhead reduction when running PFT test > comparing {CONFIG_MEMCG=n} against {CONFIG_MEMCG=y, cgroup_disable=memory} > configuration on an 8-core ARM64 Android device. > > Signed-off-by: Suren Baghdasaryan <surenb@google.com> > Reviewed-by: Shakeel Butt <shakeelb@google.com> > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
LGTM.
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
| |