Messages in this thread | | | Subject | Re: [PATCH] perf llvm: Fix error return code in llvm__compile_bpf() | From | Zhihao Cheng <> | Date | Fri, 2 Jul 2021 11:01:27 +0800 |
| |
在 2021/7/2 1:20, Arnaldo Carvalho de Melo 写道: > Em Wed, Jun 09, 2021 at 07:59:45PM +0800, Zhihao Cheng escreveu: >> Fix to return a negative error code from the error handling >> case instead of 0, as done elsewhere in this function. > > I checked and llvm__compile_bpf() returns -errno, so I'll change this to > instead set err to -ENOMEM just before the if (asprintf)(), ok? > > - Arnaldo > Glad to accept this change. >> Fixes: cb76371441d098 ("perf llvm: Allow passing options to llc ...") >> Fixes: 5eab5a7ee032ac ("perf llvm: Display eBPF compiling command ...") >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
| |