Messages in this thread | | | Subject | Re: [PATCH net-next v1 1/1] net: usb: asix: ax88772: suspend PHY on driver probe | From | Florian Fainelli <> | Date | Thu, 1 Jul 2021 12:01:04 -0700 |
| |
On 6/28/21 9:43 PM, Oleksij Rempel wrote: > After probe/bind sequence is the PHY in active state, even if interface > is stopped. As result, on some systems like Samsung Exynos5250 SoC based Arndale > board, the ASIX PHY will be able to negotiate the link but fail to > transmit the data. > > To handle it, suspend the PHY on probe.
Very unusual, could not the PHY be attached/connected to a ndo_open() time like what most drivers do?
> > Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/net/usb/asix_devices.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c > index aec97b021a73..2c115216420a 100644 > --- a/drivers/net/usb/asix_devices.c > +++ b/drivers/net/usb/asix_devices.c > @@ -701,6 +701,7 @@ static int ax88772_init_phy(struct usbnet *dev) > return ret; > } > > + phy_suspend(priv->phydev); > priv->phydev->mac_managed_pm = 1; > > phy_attached_info(priv->phydev); >
-- Florian
| |