Messages in this thread | | | Date | Thu, 1 Jul 2021 15:03:10 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v2] perf annotate: allow 's' on source code lines |
| |
Em Tue, Jun 29, 2021 at 08:00:31AM -0700, Ian Rogers escreveu: > On Fri, Jun 25, 2021 at 8:53 AM Riccardo Mancini <rickyman7@gmail.com> wrote: > > On Thu, 2021-06-24 at 22:37 -0700, Ian Rogers wrote: > > > On Thu, Jun 24, 2021 at 3:37 PM Riccardo Mancini <rickyman7@gmail.com> wrote: > > > comment nit, perhaps prefer "closest" rather than "next" due to > > > searching backward. > > > > The backward search is just a fallback in case the forward one finds no asm > > line, which I believe is unlikely. Maybe it's also impossible, but I don't > > really know how those lines are generated, so I put a fallback in place. > > Furthermore, "closest" would imply that a previous asm line could be chosen over > > a subsequent one if closer, even if the latter is present. > > > > Thanks, > > Riccardo > > Agreed, thanks for thinking about this. > > Acked-by: Ian Rogers <irogers@google.com>
Thanks, applied.
- Arnaldo
| |