Messages in this thread | | | Date | Fri, 2 Jul 2021 00:41:00 +0800 | From | kernel test robot <> | Subject | Re: [PATCH] nohz: nohz idle balancing per node |
| |
Hi Nicholas,
I love your patch! Yet something to improve:
[auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.13] [cannot apply to tip/sched/core next-20210701] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/nohz-nohz-idle-balancing-per-node/20210701-135507 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c54b245d011855ea91c5beff07f1db74143ce614 config: x86_64-randconfig-a016-20210630 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project e7e71e9454ed76c1b3d8140170b5333c28bef1be) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/1bede18329ddbaed4099e980fdf62092ff881932 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Nicholas-Piggin/nohz-nohz-idle-balancing-per-node/20210701-135507 git checkout 1bede18329ddbaed4099e980fdf62092ff881932 # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' if (static_branch_unlikely(&housekeeping_overridden)) { ^ >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' >> kernel/sched/fair.c:11590:30: error: use of undeclared identifier 'housekeeping_overridden' fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated.
vim +/housekeeping_overridden +11590 kernel/sched/fair.c
11583 11584 __init void init_sched_fair_class(void) 11585 { 11586 #ifdef CONFIG_SMP 11587 open_softirq(SCHED_SOFTIRQ, run_rebalance_domains); 11588 11589 #ifdef CONFIG_NO_HZ_COMMON 11590 if (static_branch_unlikely(&housekeeping_overridden)) { 11591 struct nohz *nohz; 11592 11593 nohz_nodes = kcalloc(1, sizeof(struct nohz *), GFP_NOWAIT); 11594 nohz = kmalloc(sizeof(struct nohz), GFP_NOWAIT); 11595 nohz->next_balance = jiffies; 11596 nohz->next_blocked = jiffies; 11597 zalloc_cpumask_var(&nohz->idle_cpus_mask, GFP_NOWAIT); 11598 nohz_nodes[0] = nohz; 11599 } else { 11600 int n; 11601 11602 nohz_nodes = kcalloc(nr_node_ids, sizeof(struct nohz *), GFP_NOWAIT); 11603 for_each_node(n) { 11604 struct nohz *nohz; 11605 11606 nohz = kmalloc_node(sizeof(struct nohz), GFP_NOWAIT, n); 11607 nohz->next_balance = jiffies; 11608 nohz->next_blocked = jiffies; 11609 zalloc_cpumask_var_node(&nohz->idle_cpus_mask, GFP_NOWAIT, n); 11610 nohz_nodes[n] = nohz; 11611 } 11612 } 11613 #endif 11614 #endif /* SMP */ 11615
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |