Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH] staging: rtl8188eu: Replace a custom function with crc32_le() | Date | Thu, 1 Jul 2021 15:54:49 +0000 |
| |
From: Fabio M. De Francesco > Sent: 01 July 2021 16:24 > > On Thursday, July 1, 2021 4:52:08 PM CEST David Laight wrote: > > From: Fabio M. De Francesco > > > > > Sent: 01 July 2021 14:38 > > > > > > Use crc32_le in place of the custom getcrc32. This change makes GCC > > > to warn about incorrect castings to the restricted type __le32, but > > > they can be safely ignored because crc32_le calculates bitwise > > > little-endian Ethernet AUTODIN II CRC32. > > > > ... > > > > > - *((__le32 *)crc) = > getcrc32(payload, length);/* modified by Amy*/ > > > + *((__le32 *)crc) = > ~crc32_le(~0, payload, length); > > > > Haven't we been round this before? > > > No, I don't think so. At least, not you and I. >
That was rt1872 this is rtl8188 but I think it is the same crap.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |