lkml.org 
[lkml]   [2021]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/4] PCI: replace dublicated MRRS limit quirks
    [+cc Huacai]

    On Sat, Jun 19, 2021 at 02:39:48PM +0800, Artem Lapkin wrote:
    > Replace dublicated MRRS limit quirks by mrrs_limit_quirk from core
    > * drivers/pci/controller/dwc/pci-keystone.c
    > * drivers/pci/controller/pci-loongson.c

    s/dublicated/duplicated/ (several occurrences)

    Capitalize subject lines.

    Use "git log --online" to learn conventions and follow them.

    Add "()" after function names.

    Capitalize acronyms appropriately (NVMe, MRRS, PCI, etc).

    End sentences with periods.

    A "move" patch must include both the removal and the addition and make
    no changes to the code itself.

    Amlogic appears without explanation in 2/4. Must be separate patch to
    address only that specific issue. Should reference published erratum
    if possible. "Solves some issue" is not a compelling justification.

    The tree must be consistent and functionally the same or improved
    after every patch.

    Add to pci_ids.h only if symbol used more than one place.

    See
    https://lore.kernel.org/r/20210701074458.1809532-3-chenhuacai@loongson.cn,
    which looks similar. Combine efforts if possible and cc Huacai so
    you're both aware of overlapping work.

    More hints in case they're useful:
    https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/

    > Both ks_pcie_quirk loongson_mrrs_quirk was rewritten without any
    > functionality changes by one mrrs_limit_quirk
    >
    > Added DesignWare PCI controller which need same quirk for
    > * drivers/pci/controller/dwc/pci-meson.c (PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3)
    >
    > This quirk can solve some issue for Khadas VIM3/VIM3L(Amlogic)
    > with HDMI scrambled picture and nvme devices at intensive writing...
    >
    > come from:
    > * https://lore.kernel.org/linux-pci/20210618063821.1383357-1-art@khadas.com/
    >
    > Artem Lapkin (4):
    > PCI: move Keystone and Loongson device IDs to pci_ids
    > PCI: core: quirks: add mrrs_limit_quirk
    > PCI: keystone move mrrs quirk to core
    > PCI: loongson move mrrs quirk to core
    >
    > --
    > 2.25.1
    >

    \
     
     \ /
      Last update: 2021-07-01 17:47    [W:3.868 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site