Messages in this thread Patch in this message | | | From | gushengxian <> | Subject | [PATCH] tools: bpftool: close va_list 'ap' by va_end() | Date | Thu, 1 Jul 2021 05:00:26 -0700 |
| |
From: gushengxian <gushengxian@yulong.com>
va_list 'ap' was opened but not closed by va_end(). It should be closed by va_end() before return.
Signed-off-by: gushengxian <gushengxian@yulong.com> --- tools/bpf/bpftool/jit_disasm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/bpf/bpftool/jit_disasm.c b/tools/bpf/bpftool/jit_disasm.c index e7e7eee9f172..3c85fd1f00cb 100644 --- a/tools/bpf/bpftool/jit_disasm.c +++ b/tools/bpf/bpftool/jit_disasm.c @@ -45,8 +45,10 @@ static int fprintf_json(void *out, const char *fmt, ...) char *s; va_start(ap, fmt); - if (vasprintf(&s, fmt, ap) < 0) + if (vasprintf(&s, fmt, ap) < 0) { + va_end(ap); return -1; + } va_end(ap); if (!oper_count) { -- 2.25.1
| |