lkml.org 
[lkml]   [2021]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup
From
Date
On 2021-07-01 01:40, Dennis Gilmore wrote:
> Without the usbdrd_dwc3_1 node defined u-boot will throw an error and
> reset the system. All other rk3399 systems use this format

This doesn't make much sense - the usbdrd_dwc3_1 label is defined in
rk3399.dtsi either way, and the compiled DTBs before and after are
identical :/

If U-Boot is doing something funny with labels and symbols to give
itself some kind of fragile dependency, that probably wants to be fixed
in U-Boot.

Robin.

> Signed-off-by: Dennis Gilmore <dgilmore@redhat.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index 738cfd21df3e..aeedf098f67c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> @@ -490,9 +490,9 @@ &uart2 {
>
> &usbdrd3_1 {
> status = "okay";
> +};
>
> - usb@fe900000 {
> - dr_mode = "host";
> - status = "okay";
> - };
> +&usbdrd_dwc3_1 {
> + dr_mode = "host";
> + status = "okay";
> };
>

\
 
 \ /
  Last update: 2021-07-01 11:35    [W:0.121 / U:1.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site