Messages in this thread | | | Date | Wed, 9 Jun 2021 08:40:08 +0200 | From | Christian Brauner <> | Subject | Re: [PATCH] proc: Track /proc/$pid/attr/ opener mm_struct |
| |
On Tue, Jun 08, 2021 at 10:12:21AM -0700, Kees Cook wrote: > Commit bfb819ea20ce ("proc: Check /proc/$pid/attr/ writes against file opener") > tried to make sure that there could not be a confusion between the opener of > a /proc/$pid/attr/ file and the writer. It used struct cred to make sure > the privileges didn't change. However, there were existing cases where a more > privileged thread was passing the opened fd to a differently privileged thread > (during container setup). Instead, use mm_struct to track whether the opener > and writer are still the same process. (This is what several other proc files > already do, though for different reasons.) > > Reported-by: Christian Brauner <christian.brauner@ubuntu.com> > Reported-by: Andrea Righi <andrea.righi@canonical.com> > Tested-by: Andrea Righi <andrea.righi@canonical.com> > Fixes: bfb819ea20ce ("proc: Check /proc/$pid/attr/ writes against file opener") > Cc: stable@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org> > ---
Thanks! Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
| |