Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 9 Jun 2021 08:26:58 +0200 | Subject | Re: [PATCH v2 1/2] m68k/mac: Replace macide driver with generic platform drivers |
| |
On Tue, Jun 8, 2021 at 8:04 AM Finn Thain <fthain@linux-m68k.org> wrote: > This allows m68k mac systems to switch from the deprecated IDE subsystem > to libata. > > This was tested on my Quadra 630. I haven't tested it on my PowerBook 150 > because I don't have a RAM adapter board for it. It appears that the > hardware I tested doesn't need macide_clear_irq() or macide_test_irq(). > If it did, the generic driver would not have worked. It's possible that > those routines are needed for the PowerBook 150 but we can cross that > bridge if and when we come to it. > > BTW, macide_clear_irq() appears to suffer from a race condition. The write > to the interrupt flags register could have unintended side effects as it > may alter other flag bits. Fortunately, all of the other bits are unused > by Linux. When tested on my Quadra 630, the assignment *ide_ifr &= ~0x20 > was observed to have no effect on bit 5, so it may be redundant anyway. > > Cc: Michael Schmitz <schmitzmic@gmail.com> > Cc: Joshua Thompson <funaho@jurai.org> > Reviewed-by: Michael Schmitz <schmitzmic@gmail.com> > Signed-off-by: Finn Thain <fthain@linux-m68k.org>
Thanks for your patch!
> arch/m68k/configs/mac_defconfig | 1 - > arch/m68k/configs/multi_defconfig | 1 - > arch/m68k/mac/config.c | 24 +++-- > drivers/ide/Kconfig | 14 --- > drivers/ide/Makefile | 1 - > drivers/ide/macide.c | 161 ------------------------------ > 6 files changed, 14 insertions(+), 188 deletions(-) > delete mode 100644 drivers/ide/macide.c
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |