lkml.org 
[lkml]   [2021]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC v2 01/34] mm, slub: don't call flush_all() from list_locations()
    Date
    list_locations() can only be called on caches with SLAB_STORE_USER flag and as
    with all slub debugging flags, such caches avoid cpu or percpu partial slabs
    altogether, so there's nothing to flush.

    Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
    ---
    mm/slub.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/mm/slub.c b/mm/slub.c
    index 3f96e099817a..f928607230b2 100644
    --- a/mm/slub.c
    +++ b/mm/slub.c
    @@ -4839,8 +4839,6 @@ static int list_locations(struct kmem_cache *s, char *buf,
    GFP_KERNEL)) {
    return sysfs_emit(buf, "Out of memory\n");
    }
    - /* Push back cpu slabs */
    - flush_all(s);

    for_each_kmem_cache_node(s, node, n) {
    unsigned long flags;
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-06-09 13:40    [W:4.086 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site