lkml.org 
[lkml]   [2021]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2][next][V2] net: usb: asix: ax88772: Fix less than zero comparison of a u16
Date
From: Colin Ian King <colin.king@canonical.com>

The comparison of the u16 priv->phy_addr < 0 is always false because
phy_addr is unsigned. Fix this by assigning the return from the call
to function asix_read_phy_addr to int ret and using this for the
less than zero error check comparison.

Fixes: 7e88b11a862a ("net: usb: asix: refactor asix_read_phy_addr() and handle errors on return")
Addresses-Coverity: ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---

V2: fix up return check.

---
drivers/net/usb/ax88172a.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/usb/ax88172a.c b/drivers/net/usb/ax88172a.c
index 2e2081346740..530947d7477b 100644
--- a/drivers/net/usb/ax88172a.c
+++ b/drivers/net/usb/ax88172a.c
@@ -205,11 +205,11 @@ static int ax88172a_bind(struct usbnet *dev, struct usb_interface *intf)
goto free;
}

- priv->phy_addr = asix_read_phy_addr(dev, priv->use_embdphy);
- if (priv->phy_addr < 0) {
- ret = priv->phy_addr;
+ ret = asix_read_phy_addr(dev, priv->use_embdphy);
+ if (ret < 0)
goto free;
- }
+
+ priv->phy_addr = ret;

ax88172a_reset_phy(dev, priv->use_embdphy);

--
2.31.1
\
 
 \ /
  Last update: 2021-06-09 12:25    [W:0.036 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site