Messages in this thread | | | Subject | Re: [PATCH 10/11] vfio-pci: introduce vfio_pci_core subsystem driver | From | Max Gurtovoy <> | Date | Wed, 9 Jun 2021 12:29:27 +0300 |
| |
On 6/9/2021 12:26 AM, Alex Williamson wrote: > On Thu, 3 Jun 2021 19:08:08 +0300 > Max Gurtovoy <mgurtovoy@nvidia.com> wrote: >> diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig >> index 5e2e1b9a9fd3..384d06661f30 100644 >> --- a/drivers/vfio/pci/Kconfig >> +++ b/drivers/vfio/pci/Kconfig >> @@ -1,6 +1,6 @@ >> # SPDX-License-Identifier: GPL-2.0-only >> -config VFIO_PCI >> - tristate "VFIO support for PCI devices" >> +config VFIO_PCI_CORE >> + tristate "VFIO core support for PCI devices" >> depends on VFIO && PCI && EVENTFD >> depends on MMU >> select VFIO_VIRQFD >> @@ -11,9 +11,17 @@ config VFIO_PCI >> >> If you don't know what to do here, say N. >> >> +config VFIO_PCI >> + tristate "VFIO support for PCI devices" >> + depends on VFIO_PCI_CORE >> + help >> + This provides a generic PCI support using the VFIO framework. >> + >> + If you don't know what to do here, say N. >> + > I think it's going to generate a lot of user and distro frustration to > hide VFIO_PCI behind a new VFIO_PCI_CORE option. The core should be a > dependency *selected* by the drivers, not a prerequisite for the > driver. Thanks,
I'll fix that. Thanks.
> > Alex >
| |