Messages in this thread | | | Subject | Re: [PATCH v2] perf stat: Disable NMI watchdog message on hybrid | From | "Jin, Yao" <> | Date | Thu, 10 Jun 2021 09:04:57 +0800 |
| |
Hi Jiri,
On 6/10/2021 4:26 AM, Jiri Olsa wrote: >> +static bool is_mixed_hybrid_group(struct evsel *counter) >> +{ >> + struct evlist *evlist = counter->evlist; >> + struct evsel *pos; >> + >> + evlist__for_each_entry(evlist, pos) { >> + if (perf_pmu__is_hybrid(pos->pmu_name)) >> + return true; >> + } > so we care if there's at least one hybrid event in the list right? > it can be all full with just hybrid events, but the function name > suggests it's mixed with normal events > > jirka >
Yes, that's right. We only care there is at least one hybrid event in the evlist.
So do we change the function name to evlist__has_hybrid_event?
Thanks Jin Yao
| |