lkml.org 
[lkml]   [2021]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/1] i2c: cht-wc: Replace of_node by NULL
From
Date
Hi,

On 6/9/21 7:30 PM, Andy Shevchenko wrote:
> The driver is run on the platforms where OF node is always NULL.
> The confusion comes from IRQ domain APIs that take either OF or
> firmware node as input parameter. Since fwnode is not used here
> either, replace of_node by NULL.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: rewrote in order to pass NULL instead of of_node (Hans)
> drivers/i2c/busses/i2c-cht-wc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



>
> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
> index 08f491ea21ac..1cf68f85b2e1 100644
> --- a/drivers/i2c/busses/i2c-cht-wc.c
> +++ b/drivers/i2c/busses/i2c-cht-wc.c
> @@ -354,8 +354,7 @@ static int cht_wc_i2c_adap_i2c_probe(struct platform_device *pdev)
> return ret;
>
> /* Alloc and register client IRQ */
> - adap->irq_domain = irq_domain_add_linear(pdev->dev.of_node, 1,
> - &irq_domain_simple_ops, NULL);
> + adap->irq_domain = irq_domain_add_linear(NULL, 1, &irq_domain_simple_ops, NULL);
> if (!adap->irq_domain)
> return -ENOMEM;
>
>

\
 
 \ /
  Last update: 2021-06-09 19:33    [W:0.131 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site