Messages in this thread | | | Date | Tue, 8 Jun 2021 19:20:14 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] events: core: make perf_pmu_snapshot_aux static |
| |
On Tue, Jun 08, 2021 at 07:22:53PM +0300, Pavel Skripkin wrote: > Sparse says: > warning: symbol 'perf_pmu_snapshot_aux' was not declared. Should it be static? > > Since perf_pmu_snapshot_aux() is not used outside this file, > it can be made static > > Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> > --- > kernel/events/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 6fee4a7e88d7..0d98d6a6f949 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -6667,7 +6667,7 @@ static unsigned long perf_prepare_sample_aux(struct perf_event *event, > return data->aux_size; > } > > -long perf_pmu_snapshot_aux(struct perf_buffer *rb, > +static long perf_pmu_snapshot_aux(struct perf_buffer *rb, > struct perf_event *event, > struct perf_output_handle *handle, > unsigned long size)
You've just ruined the alignment of the arguments, also you subject has the wrong prefix, see to git log for suggestions.
| |