lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][next] ima: Fix fall-through warning for Clang
    On Mon, Jun 07, 2021 at 03:49:34PM -0500, Gustavo A. R. Silva wrote:
    > In preparation to enable -Wimplicit-fallthrough for Clang, fix a
    > fall-through warning by explicitly adding a break statement instead
    > of just letting the code fall through to the next case.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    > ---
    > JFYI: We had thousands of these sorts of warnings and now we are down
    > to just 13 in linux-next(20210607). This is one of those last
    > remaining warnings. :)

    Looks right to me; thanks!

    Reviewed-by: Kees Cook <keescook@chromium.org>

    >
    > security/integrity/ima/ima_template_lib.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/security/integrity/ima/ima_template_lib.c b/security/integrity/ima/ima_template_lib.c
    > index 518fd50ea48a..8f96247b4a5c 100644
    > --- a/security/integrity/ima/ima_template_lib.c
    > +++ b/security/integrity/ima/ima_template_lib.c
    > @@ -119,6 +119,7 @@ static void ima_show_template_data_ascii(struct seq_file *m,
    > default:
    > break;
    > }
    > + break;
    > default:
    > break;
    > }
    > --
    > 2.27.0
    >

    --
    Kees Cook

    \
     
     \ /
      Last update: 2021-06-08 19:04    [W:2.362 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site