Messages in this thread | | | Subject | Re: [PATCH RESEND] arm64: meson: select COMMON_CLK | From | Neil Armstrong <> | Date | Tue, 8 Jun 2021 18:38:30 +0200 |
| |
Hi,
On 08/06/2021 18:32, Jerome Brunet wrote: > > On Tue 08 Jun 2021 at 11:52, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> Hi Jerome, >> >> On Tue, May 4, 2021 at 2:06 AM Kevin Hilman <khilman@baylibre.com> wrote: >>> On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote: >>>> This fix the recent removal of clock drivers selection. >>>> While it is not necessary to select the clock drivers themselves, we need >>>> to select a proper implementation of the clock API, which for the meson, is >>>> CCF >>> >>> Applied, thanks! >>> >>> [1/1] arm64: meson: select COMMON_CLK >>> commit: aea7a80ad5effd48f44a7a08c3903168be038a43 >>> >>> Best regards, >>> -- >>> Kevin Hilman <khilman@baylibre.com> >> >> Why is this needed, and why would this make any difference? >> COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in >> arch/arm64/Kconfig selects it. > > Ah indeed. Shortly after commit ba66a25536dd was merged I remember I had > problem with COMMON_CLK (or any other clock implementation) being > selected. TBH, I don't remember it exactly ... > > For sure this was a mistake. > Neil, can you still drop it and do you need a revert ? I can't drop it, it has already been merged.
Please send a revert and I'll push it for 5.14-rc fixes.
Neil
> >> >> Gr{oetje,eeting}s, >> >> Geert >
| |