Messages in this thread | | | Subject | Re: [PATCH v2 3/3] KVM: X86: Let's harden the ipi fastpath condition edge-trigger mode | From | Paolo Bonzini <> | Date | Tue, 8 Jun 2021 18:27:35 +0200 |
| |
On 07/06/21 09:19, Wanpeng Li wrote: > From: Wanpeng Li <wanpengli@tencent.com> > > Let's harden the ipi fastpath condition edge-trigger mode.
This is not a good commit message... And if it's a bug, it needs a kvm-unit-tests testcase.
Paolo
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com> > --- > arch/x86/kvm/x86.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index b594275..dbd3e9d 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -1922,6 +1922,7 @@ static int handle_fastpath_set_x2apic_icr_irqoff(struct kvm_vcpu *vcpu, u64 data > return 1; > > if (((data & APIC_SHORT_MASK) == APIC_DEST_NOSHORT) && > + ((data & APIC_INT_LEVELTRIG) == 0) && > ((data & APIC_DEST_MASK) == APIC_DEST_PHYSICAL) && > ((data & APIC_MODE_MASK) == APIC_DM_FIXED) && > ((u32)(data >> 32) != X2APIC_BROADCAST)) { >
| |