Messages in this thread | | | Subject | Re: [PATCH v2 0/7] fuse: Some fixes for submounts | From | Max Reitz <> | Date | Tue, 8 Jun 2021 17:52:13 +0200 |
| |
On 04.06.21 18:11, Greg Kurz wrote: > v2: > > - add an extra fix (patch 2) : mount is now added to the list before > unlocking sb->s_umount > - set SB_BORN just before unlocking sb->s_umount, just like it would > happen when using fc_mount() (Max) > - don't allocate a FUSE context for the submounts (Max) > - introduce a dedicated context ops for submounts > - add a extra cleanup : simplify the code even more with fc_mount() > > v1: > > While working on adding syncfs() support in FUSE, I've hit some severe > bugs with submounts (a crash and an infinite loop). The fix for the > crash is straightforward (patch 1), but the fix for the infinite loop > is more invasive : as suggested by Miklos, a simple bug fix is applied > first (patch 2) and the final fix (patch 3) is applied on top.
Thanks a lot for these patches. I’ve had a style nit on patch 6, but other than that, looks nice to me.
Max
| |