lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] scsi: lpfc: Use list_move_tail instead of list_del/list_add_tail
From
Date
On 6/7/2021 5:51 PM, Zou Wei wrote:
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/scsi/lpfc/lpfc_sli.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index e2cfb86..84a9101 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -20162,8 +20162,7 @@ lpfc_cleanup_pending_mbox(struct lpfc_vport *vport)
> (mb->u.mb.mbxCommand != MBX_REG_VPI))
> continue;
>
> - list_del(&mb->list);
> - list_add_tail(&mb->list, &mbox_cmd_list);
> + list_move_tail(&mb->list, &mbox_cmd_list);
> }
> /* Clean up active mailbox command with the vport */
> mb = phba->sli.mbox_active;
>

Thanks

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james

\
 
 \ /
  Last update: 2021-06-08 17:46    [W:0.045 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site