Messages in this thread | | | From | "Deucher, Alexander" <> | Subject | RE: [PATCH] iommu/amd: Fix section mismatch warning for detect_ivrs() | Date | Tue, 8 Jun 2021 13:50:49 +0000 |
| |
[AMD Public Use]
> -----Original Message----- > From: Joerg Roedel <joro@8bytes.org> > Sent: Tuesday, June 8, 2021 8:29 AM > To: Joerg Roedel <joro@8bytes.org>; Will Deacon <will@kernel.org> > Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; > iommu@lists.linux-foundation.org; linux-kernel@vger.kernel.org; Joerg > Roedel <jroedel@suse.de> > Subject: [PATCH] iommu/amd: Fix section mismatch warning for > detect_ivrs() > > From: Joerg Roedel <jroedel@suse.de> > > A recent commit introduced this section mismatch warning: > > WARNING: modpost: vmlinux.o(.text.unlikely+0x22a1f): Section > mismatch in reference from the function detect_ivrs() to the variable > .init.data:amd_iommu_force_enable > > The reason is that detect_ivrs() is not marked __init while it should be, > because it is only called from another __init function. Mark > detect_ivrs() __init to get rid of the warning. > > Fixes: b1e650db2cc4 ("iommu/amd: Add amd_iommu=force_enable > option") > Signed-off-by: Joerg Roedel <jroedel@suse.de>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> --- > drivers/iommu/amd/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index > 4e4fb0f4e412..46280e6e1535 100644 > --- a/drivers/iommu/amd/init.c > +++ b/drivers/iommu/amd/init.c > @@ -2817,7 +2817,7 @@ static int amd_iommu_enable_interrupts(void) > return ret; > } > > -static bool detect_ivrs(void) > +static bool __init detect_ivrs(void) > { > struct acpi_table_header *ivrs_base; > acpi_status status; > -- > 2.31.1
| |