lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 2/7] usb: typec: ucsi: Don't stop alt mode registration on busy condition
On Tue, Jun 08, 2021 at 12:31:45PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 07.06.2021 16:14, Heikki Krogerus wrote:
>
> > If the PPM tells it's busy, we can now simply try again.
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > ---
> > drivers/usb/typec/ucsi/ucsi.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> > index 366c8a468bc18..a8e0e31dcddf5 100644
> > --- a/drivers/usb/typec/ucsi/ucsi.c
> > +++ b/drivers/usb/typec/ucsi/ucsi.c
> > @@ -437,8 +437,11 @@ static int ucsi_register_altmodes(struct ucsi_connector *con, u8 recipient)
> > command |= UCSI_GET_ALTMODE_CONNECTOR_NUMBER(con->num);
> > command |= UCSI_GET_ALTMODE_OFFSET(i);
> > len = ucsi_send_command(con->ucsi, command, alt, sizeof(alt));
>
> Could insert your check here, to reduce the indentation...

Sure thing.

> > - if (len <= 0)
> > + if (len <= 0) {
> > + if (len == -EBUSY)
> > + continue;
> > return len;
> > + }
> > /*
> > * This code is requesting one alt mode at a time, but some PPMs

thanks,

--
heikki

\
 
 \ /
  Last update: 2021-06-08 15:19    [W:0.460 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site