lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC v2 11/14] mm/damon/dbgfs: Support watermarks
    Date
    From: SeongJae Park <sjpark@amazon.de>

    This commit updates DAMON debugfs interface to support the watermarks
    based schemes activation. For this, now 'schemes' file receives five
    more values.

    Signed-off-by: SeongJae Park <sjpark@amazon.de>
    ---
    mm/damon/dbgfs.c | 14 ++++++++------
    1 file changed, 8 insertions(+), 6 deletions(-)

    diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c
    index 1680fb1be8e1..768ef3eb9550 100644
    --- a/mm/damon/dbgfs.c
    +++ b/mm/damon/dbgfs.c
    @@ -227,7 +227,7 @@ static ssize_t sprint_schemes(struct damon_ctx *c, char *buf, ssize_t len)

    damon_for_each_scheme(s, c) {
    rc = scnprintf(&buf[written], len - written,
    - "%lu %lu %u %u %u %u %d %lu %lu %u %u %u %lu %lu\n",
    + "%lu %lu %u %u %u %u %d %lu %lu %u %u %u %d %lu %lu %lu %lu %lu %lu\n",
    s->min_sz_region, s->max_sz_region,
    s->min_nr_accesses, s->max_nr_accesses,
    s->min_age_region, s->max_age_region,
    @@ -235,6 +235,8 @@ static ssize_t sprint_schemes(struct damon_ctx *c, char *buf, ssize_t len)
    s->limit.weight_sz,
    s->limit.weight_nr_accesses,
    s->limit.weight_age,
    + s->wmarks.metric, s->wmarks.interval,
    + s->wmarks.high, s->wmarks.mid, s->wmarks.low,
    s->stat_count, s->stat_sz);
    if (!rc)
    return -ENOMEM;
    @@ -315,18 +317,18 @@ static struct damos **str_to_schemes(const char *str, ssize_t len,
    *nr_schemes = 0;
    while (pos < len && *nr_schemes < max_nr_schemes) {
    struct damos_speed_limit limit = {};
    - struct damos_watermarks wmarks = {
    - .metric = DAMOS_WMARK_NONE,
    - };
    + struct damos_watermarks wmarks;

    ret = sscanf(&str[pos],
    - "%lu %lu %u %u %u %u %u %lu %lu %u %u %u%n",
    + "%lu %lu %u %u %u %u %u %lu %lu %u %u %u %u %lu %lu %lu %lu%n",
    &min_sz, &max_sz, &min_nr_a, &max_nr_a,
    &min_age, &max_age, &action, &limit.sz,
    &limit.ms, &limit.weight_sz,
    &limit.weight_nr_accesses, &limit.weight_age,
    + &wmarks.metric, &wmarks.interval,
    + &wmarks.high, &wmarks.mid, &wmarks.low,
    &parsed);
    - if (ret != 12)
    + if (ret != 17)
    break;
    if (!damos_action_valid(action)) {
    pr_err("wrong action %d\n", action);
    --
    2.17.1
    \
     
     \ /
      Last update: 2021-06-08 13:56    [W:4.151 / U:0.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site