Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 8 Jun 2021 12:43:13 +0200 | Subject | Re: [PATCH][next][V2] ASoC: rsnd: check for zero node count |
| |
Hi Colin,
Thanks for your patch!
On Thu, Jun 3, 2021 at 1:05 PM Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Most callers of_get_child_count() check that "nr" is non-zero so it
Note that there is no longer a call to of_get_child_count(), as of the commit referred to from the Fixes tag below.
> causes a static checker warning when we don't do that here. This > does not cause a problem or a crash, but having zero SSUIes does not > make sense either so let's add a check. > > Addresses-Coverity: ("Unchecked return value") > Fixes: c413983eb66a ("ASoC: rsnd: adjust disabled module") > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > V2: Rephrase commit message based on Dan Carpenter's suggestion. > Thanks Dan!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |