lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v2] net: dsa: b53: Do not force CPU to be always tagged
    On Tue, Jun 08, 2021 at 02:22:04PM -0700, Florian Fainelli wrote:
    > Commit ca8931948344 ("net: dsa: b53: Keep CPU port as tagged in all
    > VLANs") forced the CPU port to be always tagged in any VLAN membership.
    > This was necessary back then because we did not support Broadcom tags
    > for all configurations so the only way to differentiate tagged and
    > untagged traffic while DSA_TAG_PROTO_NONE was used was to force the CPU
    > port into being always tagged.
    >
    > With most configurations enabling Broadcom tags, especially after
    > 8fab459e69ab ("net: dsa: b53: Enable Broadcom tags for 531x5/539x
    > families") we do not need to apply this unconditional force tagging of
    > the CPU port in all VLANs.
    >
    > A helper function is introduced to faciliate the encapsulation of the
    > specific condition requiring the CPU port to be tagged in all VLANs and
    > the dsa_switch_ops::untag_bridge_pvid boolean is moved to when
    > dsa_switch_ops::setup is called when we have already determined the
    > tagging protocol we will be using.
    >
    > Reported-by: Matthew Hagan <mnhagan88@gmail.com>
    > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    > ---

    Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

    \
     
     \ /
      Last update: 2021-06-08 23:58    [W:4.516 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site