lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 017/161] HID: pidff: fix error return code in hid_pidff_init()
    Date
    From: Zhen Lei <thunder.leizhen@huawei.com>

    [ Upstream commit 3dd653c077efda8152f4dd395359617d577a54cd ]

    Fix to return a negative error code from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: 224ee88fe395 ("Input: add force feedback driver for PID devices")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hid/usbhid/hid-pidff.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
    index fddac7c72f64..07a9fe97d2e0 100644
    --- a/drivers/hid/usbhid/hid-pidff.c
    +++ b/drivers/hid/usbhid/hid-pidff.c
    @@ -1292,6 +1292,7 @@ int hid_pidff_init(struct hid_device *hid)

    if (pidff->pool[PID_DEVICE_MANAGED_POOL].value &&
    pidff->pool[PID_DEVICE_MANAGED_POOL].value[0] == 0) {
    + error = -EPERM;
    hid_notice(hid,
    "device does not support device managed pool\n");
    goto fail;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-08 21:20    [W:3.348 / U:1.796 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site