lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 013/137] vfio/platform: fix module_put call in error flow
    Date
    From: Max Gurtovoy <mgurtovoy@nvidia.com>

    [ Upstream commit dc51ff91cf2d1e9a2d941da483602f71d4a51472 ]

    The ->parent_module is the one that use in try_module_get. It should
    also be the one the we use in module_put during vfio_platform_open().

    Fixes: 32a2d71c4e80 ("vfio: platform: introduce vfio-platform-base module")
    Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
    Message-Id: <20210518192133.59195-1-mgurtovoy@nvidia.com>
    Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/vfio/platform/vfio_platform_common.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
    index fb4b385191f2..e83a7cd15c95 100644
    --- a/drivers/vfio/platform/vfio_platform_common.c
    +++ b/drivers/vfio/platform/vfio_platform_common.c
    @@ -289,7 +289,7 @@ err_irq:
    vfio_platform_regions_cleanup(vdev);
    err_reg:
    mutex_unlock(&driver_lock);
    - module_put(THIS_MODULE);
    + module_put(vdev->parent_module);
    return ret;
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-08 20:55    [W:4.035 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site