lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 61/78] btrfs: return errors from btrfs_del_csums in cleanup_ref_head
    Date
    From: Josef Bacik <josef@toxicpanda.com>

    commit 856bd270dc4db209c779ce1e9555c7641ffbc88e upstream.

    We are unconditionally returning 0 in cleanup_ref_head, despite the fact
    that btrfs_del_csums could fail. We need to return the error so the
    transaction gets aborted properly, fix this by returning ret from
    btrfs_del_csums in cleanup_ref_head.

    Reviewed-by: Qu Wenruo <wqu@suse.com>
    CC: stable@vger.kernel.org # 4.19+
    Signed-off-by: Josef Bacik <josef@toxicpanda.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/btrfs/extent-tree.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/btrfs/extent-tree.c
    +++ b/fs/btrfs/extent-tree.c
    @@ -1879,7 +1879,7 @@ static int cleanup_ref_head(struct btrfs
    trace_run_delayed_ref_head(fs_info, head, 0);
    btrfs_delayed_ref_unlock(head);
    btrfs_put_delayed_ref_head(head);
    - return 0;
    + return ret;
    }

    static struct btrfs_delayed_ref_head *btrfs_obtain_ref_head(

    \
     
     \ /
      Last update: 2021-06-08 20:51    [W:6.085 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site