lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 06/58] vfio/pci: Fix error return code in vfio_ecap_init()
    Date
    From: Zhen Lei <thunder.leizhen@huawei.com>

    [ Upstream commit d1ce2c79156d3baf0830990ab06d296477b93c26 ]

    The error code returned from vfio_ext_cap_len() is stored in 'len', not
    in 'ret'.

    Fixes: 89e1f7d4c66d ("vfio: Add PCI device driver")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
    Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
    Message-Id: <20210515020458.6771-1-thunder.leizhen@huawei.com>
    Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/vfio/pci/vfio_pci_config.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
    index a1a26465d224..86e917f1cc21 100644
    --- a/drivers/vfio/pci/vfio_pci_config.c
    +++ b/drivers/vfio/pci/vfio_pci_config.c
    @@ -1579,7 +1579,7 @@ static int vfio_ecap_init(struct vfio_pci_device *vdev)
    if (len == 0xFF) {
    len = vfio_ext_cap_len(vdev, ecap, epos);
    if (len < 0)
    - return ret;
    + return len;
    }
    }

    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-08 20:41    [W:7.872 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site