lkml.org 
[lkml]   [2021]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 16/58] ixgbevf: add correct exception tracing for XDP
    Date
    From: Magnus Karlsson <magnus.karlsson@intel.com>

    [ Upstream commit faae81420d162551b6ef2d804aafc00f4cd68e0e ]

    Add missing exception tracing to XDP when a number of different
    errors can occur. The support was only partial. Several errors
    where not logged which would confuse the user quite a lot not
    knowing where and why the packets disappeared.

    Fixes: 21092e9ce8b1 ("ixgbevf: Add support for XDP_TX action")
    Reported-by: Jesper Dangaard Brouer <brouer@redhat.com>
    Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
    Tested-by: Vishakha Jambekar <vishakha.jambekar@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
    index a10756f0b0d8..7f94b445595c 100644
    --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
    +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
    @@ -1071,11 +1071,14 @@ static struct sk_buff *ixgbevf_run_xdp(struct ixgbevf_adapter *adapter,
    case XDP_TX:
    xdp_ring = adapter->xdp_ring[rx_ring->queue_index];
    result = ixgbevf_xmit_xdp_ring(xdp_ring, xdp);
    + if (result == IXGBEVF_XDP_CONSUMED)
    + goto out_failure;
    break;
    default:
    bpf_warn_invalid_xdp_action(act);
    /* fallthrough */
    case XDP_ABORTED:
    +out_failure:
    trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
    /* fallthrough -- handle aborts by dropping packet */
    case XDP_DROP:
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-06-08 20:40    [W:4.075 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site