lkml.org 
[lkml]   [2021]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 1/8] dt-bindings: rockchip-sfc: Bindings for Rockchip serial flash controller
    Date
    From: Chris Morgan <macromorgan@hotmail.com>

    Add bindings for the Rockchip serial flash controller. New device
    specific parameter of rockchip,sfc-no-dma included in documentation.

    Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
    Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
    ---

    Changes in v5:
    - Add support in device trees for rv1126
    - Support sfc tx_dual, tx_quad
    - Simplify the code, such as remove "rockchip_sfc_register_all"
    - Support SFC ver4 ver5

    Changes in v4:
    - Changing patch back to an "RFC". An engineer from Rockchip
    reached out to me to let me know they are working on this patch for
    upstream, I am submitting this v4 for the community to see however
    I expect Jon Lin (jon.lin@rock-chips.com) will submit new patches
    soon and these are the ones we should pursue for mainlining. Jon's
    patch series should include support for more hardware than this
    series.
    - Clean up documentation more and ensure it is correct per
    make dt_binding_check.
    - Add support in device trees for rk3036, rk3308, and rv1108.
    - Add ahb clock (hclk_sfc) support for rk3036.
    - Change rockchip_sfc_wait_fifo_ready() to use a switch statement.
    - Change IRQ code to only mark IRQ as handled if it handles the
    specific IRQ (DMA transfer finish) it is supposed to handle.

    Changes in v3:
    - Changed the name of the clocks to sfc/ahb (from clk-sfc/clk-hsfc).
    - Changed the compatible string from rockchip,sfc to
    rockchip,rk3036-sfc. A quick glance at the datasheets suggests this
    driver should work for the PX30, RK180x, RK3036, RK312x, RK3308 and
    RV1108 SoCs, and possibly more. However, I am currently only able
    to test this on a PX30 (an RK3326). The technical reference manuals
    appear to list the same registers for each device.
    - Corrected devicetree documentation for formatting and to note these
    changes.
    - Replaced the maintainer with Heiko Stuebner and myself, as we will
    take ownership of this going forward.
    - Noted that the device (per the reference manual) supports 4 CS, but
    I am only able to test a single CS (CS 0).
    - Reordered patches to comply with upstream rules.

    Changes in v2:
    - Reimplemented driver using spi-mem subsystem.
    - Removed power management code as I couldn't get it working properly.
    - Added device tree bindings for Odroid Go Advance.

    Changes in v1:
    hanges made in this new series versus the v8 of the old series:
    - Added function to read spi-rx-bus-width from device tree, in the
    event that the SPI chip supports 4x mode but only has 2 pins
    wired (such as the Odroid Go Advance).
    - Changed device tree documentation from txt to yaml format.
    - Made "reset" message a dev_dbg from a dev_info.
    - Changed read and write fifo functions to remove redundant checks.
    - Changed the write and read from relaxed to non-relaxed when
    starting the DMA transfer or reading the DMA IRQ.
    - Changed from dma_coerce_mask_and_coherent to just
    dma_set_mask_and_coherent.
    - Changed name of get_if_type to rockchip_sfc_get_if_type.

    .../devicetree/bindings/spi/rockchip-sfc.yaml | 86 +++++++++++++++++++
    1 file changed, 86 insertions(+)
    create mode 100644 Documentation/devicetree/bindings/spi/rockchip-sfc.yaml

    diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
    new file mode 100644
    index 000000000000..120c06f86a28
    --- /dev/null
    +++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
    @@ -0,0 +1,86 @@
    +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    +%YAML 1.2
    +---
    +$id: http://devicetree.org/schemas/spi/rockchip-sfc.yaml#
    +$schema: http://devicetree.org/meta-schemas/core.yaml#
    +
    +title: Rockchip Serial Flash Controller (SFC)
    +
    +maintainers:
    + - Heiko Stuebner <heiko@sntech.de>
    + - Chris Morgan <macromorgan@hotmail.com>
    +
    +allOf:
    + - $ref: spi-controller.yaml#
    +
    +properties:
    + compatible:
    + oneOf:
    + - const: rockchip,rk3036-sfc
    + - items:
    + - enum:
    + - rockchip,px30-sfc
    + - rockchip,rk3308-sfc
    + - rockchip,rv1108-sfc
    + - const: rockchip,rk3036-sfc
    +
    + reg:
    + maxItems: 1
    +
    + interrupts:
    + maxItems: 1
    +
    + clocks:
    + items:
    + - description: Bus Clock
    + - description: Module Clock
    +
    + clock-names:
    + items:
    + - const: ahb
    + - const: sfc
    +
    + power-domains:
    + maxItems: 1
    +
    + rockchip,sfc-no-dma:
    + description: Disable DMA and utilize FIFO mode only
    + type: boolean
    +
    +required:
    + - compatible
    + - reg
    + - interrupts
    + - clocks
    + - clock-names
    +
    +unevaluatedProperties: false
    +
    +examples:
    + - |
    + #include <dt-bindings/clock/px30-cru.h>
    + #include <dt-bindings/interrupt-controller/arm-gic.h>
    + #include <dt-bindings/power/px30-power.h>
    +
    + sfc: spi@ff3a0000 {
    + compatible = "rockchip,px30-sfc","rockchip,rk3036-sfc";
    + reg = <0xff3a0000 0x4000>;
    + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
    + clocks = <&cru HCLK_SFC>, <&cru SCLK_SFC>;
    + clock-names = "ahb", "sfc";
    + pinctrl-0 = <&sfc_clk &sfc_cs &sfc_bus2>;
    + pinctrl-names = "default";
    + power-domains = <&power PX30_PD_MMC_NAND>;
    + #address-cells = <1>;
    + #size-cells = <0>;
    +
    + flash@0 {
    + compatible = "jedec,spi-nor";
    + reg = <0>;
    + spi-max-frequency = <108000000>;
    + spi-rx-bus-width = <2>;
    + spi-tx-bus-width = <2>;
    + };
    + };
    +
    +...
    --
    2.17.1


    \
     
     \ /
      Last update: 2021-06-07 14:45    [W:3.081 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site