Messages in this thread | | | Date | Mon, 7 Jun 2021 09:15:53 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] x86/kprobes: remove free_insn_page since it is same with the common weak function |
| |
On Tue, Jun 01, 2021 at 04:08:56PM +1200, Barry Song wrote: > free_insn_page() in x86 is same with the common weak function in > kernel/kprobes.c. Plus, its comment "Recover page to RW mode before > releasing it" seems insensible to be there since resetting mapping > is done by common code in vfree() of module_memfree(). > So drop the strong function and its comment in x86 totally. > > Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
It also is the same for s390, so please remove that as well and remove the __weak.
| |