Messages in this thread | | | From | Fāng-ruì Sòng <> | Date | Mon, 7 Jun 2021 11:27:27 -0700 | Subject | Re: [PATCH v3 16/16] objtool,x86: Rewrite retpoline thunk calls |
| |
On Mon, Jun 7, 2021 at 11:19 AM Peter Zijlstra <peterz@infradead.org> wrote: > > On Sat, Jun 05, 2021 at 06:58:39PM -0700, Fāng-ruì Sòng wrote: > > > You may use https://github.com/llvm/llvm-project/blob/main/llvm/tools/llvm-objcopy/ELF/Object.cpp#L843 > > as a reference. > > BTW, Error::success(), is that a successfull error, or an erroneous > success? :-))
A success (no error). Error::success() is a factory member function. Its purpose is to create an "unchecked" Error instance and require the caller to explicitly check for the error state.
| |