Messages in this thread | | | From | Sergio Paracuellos <> | Date | Mon, 7 Jun 2021 09:12:05 +0200 | Subject | Re: [PATCH v2] pinctrl: ralink: pinctrl-rt2880: avoid to error in calls if pin is already enabled |
| |
Hi Linus,
On Mon, Jun 7, 2021 at 9:10 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Fri, Jun 4, 2021 at 7:55 AM Sergio Paracuellos > <sergio.paracuellos@gmail.com> wrote: > > > In 'rt2880_pmx_group_enable' driver is printing an error and returning > > -EBUSY if a pin has been already enabled. This becomes in anoying messages > > in the caller when this happens like the following: > > > > rt2880-pinmux pinctrl: pcie is already enabled > > mt7621-pci 1e140000.pcie: Error applying setting, reverse things back > > > > To avoid this just print the already enabled message in the pinctrl > > driver and return 0 instead to don't confuse the user with a real > > bad problem. > > > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > --- > > Changes in v2: > > - Fix commit message s/is/if > > I just fixed up the commit manually instead, no big deal.
Oh, I see :)
Thanks!! Sergio Paracuellos > > Thanks! > Linus Walleij
| |