lkml.org 
[lkml]   [2021]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] pinctrl: ralink: pinctrl-rt2880: avoid to error in calls if pin is already enabled
Hi Linus,

On Mon, Jun 7, 2021 at 9:10 AM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Fri, Jun 4, 2021 at 7:55 AM Sergio Paracuellos
> <sergio.paracuellos@gmail.com> wrote:
>
> > In 'rt2880_pmx_group_enable' driver is printing an error and returning
> > -EBUSY if a pin has been already enabled. This becomes in anoying messages
> > in the caller when this happens like the following:
> >
> > rt2880-pinmux pinctrl: pcie is already enabled
> > mt7621-pci 1e140000.pcie: Error applying setting, reverse things back
> >
> > To avoid this just print the already enabled message in the pinctrl
> > driver and return 0 instead to don't confuse the user with a real
> > bad problem.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > ---
> > Changes in v2:
> > - Fix commit message s/is/if
>
> I just fixed up the commit manually instead, no big deal.

Oh, I see :)

Thanks!!
Sergio Paracuellos
>
> Thanks!
> Linus Walleij

\
 
 \ /
  Last update: 2021-06-07 09:13    [W:0.106 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site