lkml.org 
[lkml]   [2021]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2-fix-v2 1/1] x86: Introduce generic protected guest abstraction
On Mon, Jun 07, 2021 at 11:01:05AM -0700, Kuppuswamy, Sathyanarayanan wrote:
> Why move this header outside CONFIG_INTEL_TDX_GUEST or
> CONFIG_AMD_MEM_ENCRYPT ifdef?

Because asm headers are usually included at the beginning of another,
possibly generic header. Unless you have a specially particular
reason to put them in additional guarding ifdeffery. Have a look at
include/linux/.

> This header only exists in x86 arch code. So it is better to protect
> it with x86 specific header file.

That doesn't sound like a special reason to me. And compilers are
usually very able at discarding unused symbols so I don't see a problem
with keeping all includes at the top, like it is usually done.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

\
 
 \ /
  Last update: 2021-06-07 20:27    [W:1.088 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site